Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2211)

Unified Diff: content/common/sandbox_win.cc

Issue 418943003: Close "Internet Settings" key in the sandbox (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: version Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/sandbox_win.cc
diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc
index dc2f2eb555f1fab5b2f1169184035873b925028d..b56b74a8f0f1736c71aa3b92c3be0953f39121a4 100644
--- a/content/common/sandbox_win.cc
+++ b/content/common/sandbox_win.cc
@@ -351,6 +351,12 @@ bool AddPolicyForSandboxedProcess(sandbox::TargetPolicy* policy) {
if (base::win::GetVersion() > base::win::VERSION_WIN7)
policy->AddKernelObjectToClose(L"File", L"\\Device\\DeviceApi");
+ // Close the proxy settings on XP.
+ if (base::win::GetVersion() <= base::win::VERSION_SERVER_2003)
+ policy->AddKernelObjectToClose(L"Key",
+ L"HKCU\\Software\\Microsoft\\Windows\\" \
+ L"CurrentVersion\\Internet Settings");
+
sandbox::TokenLevel initial_token = sandbox::USER_UNPROTECTED;
if (base::win::GetVersion() > base::win::VERSION_XP) {
// On 2003/Vista the initial token has to be restricted if the main
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698