Issue 418783002: Revert 178571 "Teach ContentSecurityPolicy about WebURLRequest::..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 418783002: Revert 178571 "Teach ContentSecurityPolicy about WebURLRequest::..." (Closed)

Created:
6 years, 5 months ago by haraken

Modified:
6 years, 5 months ago

Reviewers:
Mike West

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

More Reviews

Description

Revert 178571 "Teach ContentSecurityPolicy about WebURLRequest::..." Due to bug 396582. > Teach ContentSecurityPolicy about WebURLRequest::RequestContext. > > Rather than using `Resource::Type` to make decisions about what CSP > directive to apply to a resource request, we should be using > WebURLRequest::RequestContext. This patch teaches ContentSecurityPolicy > to correctly compare a URL against the right policy directive when given > a 'ResourceContext', and pipes the value through > 'ResourceFetcher::canRequest' to make sure its available when it needs > to be. > > BUG=390497 > > Review URL: https://codereview.chromium.org/398313002 TBR=mkwst@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178797

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -108 lines)			Patch
M	trunk/Source/core/fetch/CachingCorrectnessTest.cpp	View	5 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/Source/core/fetch/ResourceFetcher.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	trunk/Source/core/fetch/ResourceFetcher.cpp	View	8 chunks	+48 lines, -11 lines	0 comments	Download
M	trunk/Source/core/frame/UseCounter.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/Source/core/frame/csp/ContentSecurityPolicy.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/Source/core/frame/csp/ContentSecurityPolicy.cpp	View	1 chunk	+0 lines, -72 lines	0 comments	Download
M	trunk/Source/core/html/parser/HTMLResourcePreloader.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/Source/core/loader/ImageLoader.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/Source/core/xml/XSLTProcessorLibxslt.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/Source/core/xml/parser/XMLDocumentParser.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	trunk/Source/web/tests/WebFrameTest.cpp	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r178797.

Expand Messages | Collapse Messages