Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 398313002: Teach ContentSecurityPolicy about WebURLRequest::RequestContext. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin
Project:
blink
Visibility:
Public.

Description

Teach ContentSecurityPolicy about WebURLRequest::RequestContext. Rather than using `Resource::Type` to make decisions about what CSP directive to apply to a resource request, we should be using WebURLRequest::RequestContext. This patch teaches ContentSecurityPolicy to correctly compare a URL against the right policy directive when given a 'ResourceContext', and pipes the value through 'ResourceFetcher::canRequest' to make sure its available when it needs to be. BUG=390497 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178571

Patch Set 1 #

Patch Set 2 : Fix? #

Patch Set 3 : Grr. #

Patch Set 4 : Excluding RequestContextPlugin. #

Total comments: 2

Patch Set 5 : UseCounter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -52 lines) Patch
M Source/core/fetch/CachingCorrectnessTest.cpp View 1 2 3 5 chunks +7 lines, -0 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 2 3 8 chunks +11 lines, -48 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.cpp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/loader/ImageLoader.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/xml/XSLTProcessorLibxslt.cpp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike West
Mind taking a look at this, Jochen? The chromium bots are red because https://codereview.chromium.org/409563002/ hasn't ...
6 years, 5 months ago (2014-07-21 08:29:04 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/398313002/diff/120001/Source/core/frame/UseCounter.h File Source/core/frame/UseCounter.h (left): https://codereview.chromium.org/398313002/diff/120001/Source/core/frame/UseCounter.h#oldcode233 Source/core/frame/UseCounter.h:233: why delete those nice spacer lines?
6 years, 5 months ago (2014-07-21 11:31:24 UTC) #2
Mike West
https://codereview.chromium.org/398313002/diff/120001/Source/core/frame/UseCounter.h File Source/core/frame/UseCounter.h (left): https://codereview.chromium.org/398313002/diff/120001/Source/core/frame/UseCounter.h#oldcode233 Source/core/frame/UseCounter.h:233: On 2014/07/21 11:31:24, jochen wrote: > why delete those ...
6 years, 5 months ago (2014-07-21 12:48:05 UTC) #3
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-21 17:38:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/398313002/140001
6 years, 5 months ago (2014-07-21 17:39:29 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 17:42:50 UTC) #6
Message was sent while issue was closed. 
Change committed as 178571

Powered by Google App Engine
This is Rietveld 408576698