Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: content/browser/browser_url_handler_impl.cc

Issue 418733002: Prevent duplicate navigation to debug URLs from Telemetry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_url_handler_impl.cc
diff --git a/content/browser/browser_url_handler_impl.cc b/content/browser/browser_url_handler_impl.cc
index 1b7050f8ddf1d8d687670713515da9ba3a9bf3a7..43b4e3f9554828fbe9f682e616c4a76b98926ee4 100644
--- a/content/browser/browser_url_handler_impl.cc
+++ b/content/browser/browser_url_handler_impl.cc
@@ -73,22 +73,6 @@ static bool ReverseViewSource(GURL* url, BrowserContext* browser_context) {
return true;
}
-static bool DebugURLHandler(GURL* url, BrowserContext* browser_context) {
- // If running inside the Telemetry test harness, allow automated
- // navigations to access browser-side debug URLs. They must use the
- // chrome:// scheme, since the about: scheme won't be rewritten in
- // this code path.
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- cc::switches::kEnableGpuBenchmarking)) {
- if (HandleDebugURL(*url, PAGE_TRANSITION_FROM_ADDRESS_BAR)) {
- return true;
- }
- }
-
- // Circumvent processing URLs that the renderer process will handle.
- return IsRendererDebugURL(*url);
Charlie Reis 2014/07/23 23:04:17 Why is this ok to delete?
Ken Russell (switch to Gerrit) 2014/07/23 23:08:43 Yes, that's a good point. This should instead be r
vmiura 2014/07/23 23:39:59 Done. I'm not sure what that's there for, but I d
-}
-
// static
BrowserURLHandler* BrowserURLHandler::GetInstance() {
return BrowserURLHandlerImpl::GetInstance();
@@ -106,8 +90,6 @@ BrowserURLHandlerImpl* BrowserURLHandlerImpl::GetInstance() {
}
BrowserURLHandlerImpl::BrowserURLHandlerImpl() {
- AddHandlerPair(&DebugURLHandler, BrowserURLHandlerImpl::null_handler());
-
GetContentClient()->browser()->BrowserURLHandlerCreated(this);
// view-source:
« no previous file with comments | « no previous file | content/browser/frame_host/debug_urls.cc » ('j') | content/browser/frame_host/navigation_controller_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698