Prevent duplicate navigation to debug URLs from Telemetry.

content/browser/browser_url_handler_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_url_handler_impl.h"
 
 #include "base/command_line.h"
 #include "base/strings/string_util.h"
 #include "cc/base/switches.h"
 #include "content/browser/frame_host/debug_urls.h"
@@ skipping 55 matching lines @@
     return false;
 
   url::Replacements<char> repl;
   repl.SetScheme(kViewSourceScheme,
                  url::Component(0, strlen(kViewSourceScheme)));
   repl.SetPath(url->spec().c_str(), url::Component(0, url->spec().size()));
   *url = url->ReplaceComponents(repl);
   return true;
 }
 
-static bool DebugURLHandler(GURL* url, BrowserContext* browser_context) {
-  // If running inside the Telemetry test harness, allow automated
-  // navigations to access browser-side debug URLs. They must use the
-  // chrome:// scheme, since the about: scheme won't be rewritten in
-  // this code path.
-  if (CommandLine::ForCurrentProcess()->HasSwitch(
-          cc::switches::kEnableGpuBenchmarking)) {
-    if (HandleDebugURL(*url, PAGE_TRANSITION_FROM_ADDRESS_BAR)) {
-      return true;
-    }
-  }
-
-  // Circumvent processing URLs that the renderer process will handle.
-  return IsRendererDebugURL(*url);

[Charlie Reis, 2014/07/23 23:04:17]

Why is this ok to delete?

[Ken Russell (switch to Gerrit), 2014/07/23 23:08:43]

Yes, that's a good point. This should instead be reverted back to its state from
before crrev.com/27603004.

[vmiura, 2014/07/23 23:39:59]

Done.  I'm not sure what that's there for, but I don't see a need to remove it.

-}
-
 // static
 BrowserURLHandler* BrowserURLHandler::GetInstance() {
   return BrowserURLHandlerImpl::GetInstance();
 }
 
 // static
 BrowserURLHandler::URLHandler BrowserURLHandler::null_handler() {
   // Required for VS2010: http://connect.microsoft.com/VisualStudio/feedback/details/520043/error-converting-from-null-to-a-pointer-type-in-std-pair
   return NULL;
 }
 
 // static
 BrowserURLHandlerImpl* BrowserURLHandlerImpl::GetInstance() {
   return Singleton<BrowserURLHandlerImpl>::get();
 }
 
 BrowserURLHandlerImpl::BrowserURLHandlerImpl() {
-  AddHandlerPair(&DebugURLHandler, BrowserURLHandlerImpl::null_handler());
-
   GetContentClient()->browser()->BrowserURLHandlerCreated(this);
 
   // view-source:
   AddHandlerPair(&HandleViewSource, &ReverseViewSource);
 }
 
 BrowserURLHandlerImpl::~BrowserURLHandlerImpl() {
 }
 
 void BrowserURLHandlerImpl::AddHandlerPair(URLHandler handler,
@@ skipping 26 matching lines @@
           return true;
       } else if (handler(&test_url, browser_context)) {
         return reverse_rewriter(url, browser_context);
       }
     }
   }
   return false;
 }
 
 }  // namespace content