Shows and hides the Voice section with the hotword checkbox.

Shows and hides the Voice section with the hotword checkbox.

This prevents an empty Voice section from being shown.

BUG=395509
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285487

[Matt Giuca, 2014-07-24 06:52:09]

https://codereview.chromium.org/418693003/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/418693003/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.html:157: <div
id="voice-section-content">
I think you can put the <h3> inside this <div> and then make the hidden
attribute apply to the div (and remove it from the hotword-search div).

And update the JavaScript code accordingly. (Unless putting the <h3> inside the
<div> makes some weird styling issues.

[kcarattini, 2014-07-24 07:11:34]

https://codereview.chromium.org/418693003/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/418693003/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.html:157: <div
id="voice-section-content">
On 2014/07/24 06:52:09, Matt Giuca wrote:
> I think you can put the <h3> inside this <div> and then make the hidden
> attribute apply to the div (and remove it from the hotword-search div).
> 
> And update the JavaScript code accordingly. (Unless putting the <h3> inside
the
> <div> makes some weird styling issues.

Moving the h3 inside the div changes the indentation and would bring it out of
alignment with the other sections without more special formatting rules.

[Matt Giuca, 2014-07-24 07:13:29]

lgtm

https://codereview.chromium.org/418693003/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/browser_options.html (right):

https://codereview.chromium.org/418693003/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/browser_options.html:157: <div
id="voice-section-content">
On 2014/07/24 07:11:34, kcarattini wrote:
> On 2014/07/24 06:52:09, Matt Giuca wrote:
> > I think you can put the <h3> inside this <div> and then make the hidden
> > attribute apply to the div (and remove it from the hotword-search div).
> > 
> > And update the JavaScript code accordingly. (Unless putting the <h3> inside
> the
> > <div> makes some weird styling issues.
> 
> Moving the h3 inside the div changes the indentation and would bring it out of
> alignment with the other sections without more special formatting rules.

Acknowledged.

[James Hawkins, 2014-07-24 17:48:08]

lgtm

[kcarattini, 2014-07-25 00:23:59]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2014-07-25 00:27:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kcarattini@chromium.org/418693003/1

[commit-bot: I haz the power, 2014-07-25 05:34:57]

Change committed as 285487