Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: chrome/browser/resources/options/browser_options.html

Issue 418693003: Shows and hides the Voice section with the hotword checkbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <div id="settings" class="page" hidden> 1 <div id="settings" class="page" hidden>
2 <header> 2 <header>
3 <h1 i18n-content="settingsTitle"></h1> 3 <h1 i18n-content="settingsTitle"></h1>
4 </header> 4 </header>
5 <include src="reset_profile_settings_banner.html"> 5 <include src="reset_profile_settings_banner.html">
6 <include src="automatic_settings_reset_banner.html"> 6 <include src="automatic_settings_reset_banner.html">
7 <if expr="chromeos"> 7 <if expr="chromeos">
8 <include src="secondary_user_banner.html"> 8 <include src="secondary_user_banner.html">
9 <section> 9 <section>
10 <div id="network-section-header" class="section-header"> 10 <div id="network-section-header" class="section-header">
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 <span class="controlled-setting-indicator" 146 <span class="controlled-setting-indicator"
147 pref="default_search_provider_data.template_url_data"> 147 pref="default_search_provider_data.template_url_data">
148 </span> 148 </span>
149 <button id="manage-default-search-engines" 149 <button id="manage-default-search-engines"
150 i18n-content="defaultSearchManageEngines"> 150 i18n-content="defaultSearchManageEngines">
151 </button> 151 </button>
152 </div> 152 </div>
153 </div> 153 </div>
154 </section> 154 </section>
155 <section> 155 <section>
156 <h3 i18n-content="sectionTitleVoice"></h3> 156 <h3 id="voice-section-title" i18n-content="sectionTitleVoice" hidden></h3>
157 <div id="voice-section-content"> 157 <div id="voice-section-content">
Matt Giuca 2014/07/24 06:52:09 I think you can put the <h3> inside this <div> and
kcarattini 2014/07/24 07:11:34 Moving the h3 inside the div changes the indentati
Matt Giuca 2014/07/24 07:13:29 Acknowledged.
158 <div id="hotword-search" hidden> 158 <div id="hotword-search" hidden>
159 <div class="checkbox"> 159 <div class="checkbox">
160 <span class="controlled-setting-with-label"> 160 <span class="controlled-setting-with-label">
161 <input id="hotword-search-enable" pref="hotword.search_enabled_2" 161 <input id="hotword-search-enable" pref="hotword.search_enabled_2"
162 metric="Options_HotwordCheckbox" type="checkbox" dialog-pref> 162 metric="Options_HotwordCheckbox" type="checkbox" dialog-pref>
163 <span> 163 <span>
164 <label for="hotword-search-enable" 164 <label for="hotword-search-enable"
165 i18n-values=".innerHTML:hotwordSearchEnable"> 165 i18n-values=".innerHTML:hotwordSearchEnable">
166 </label> 166 </label>
167 <span id="hotword-search-setting-indicator" 167 <span id="hotword-search-setting-indicator"
(...skipping 786 matching lines...) Expand 10 before | Expand all | Expand 10 after
954 </div> 954 </div>
955 </section> 955 </section>
956 </div> <!-- advanced-settings-container --> 956 </div> <!-- advanced-settings-container -->
957 </div> <!-- advanced-settings --> 957 </div> <!-- advanced-settings -->
958 <footer> 958 <footer>
959 <button id="advanced-settings-expander" class="link-button" 959 <button id="advanced-settings-expander" class="link-button"
960 i18n-content="showAdvancedSettings"> 960 i18n-content="showAdvancedSettings">
961 </button> 961 </button>
962 </footer> 962 </footer>
963 </div> 963 </div>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698