Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 418573003: Remove check from SharedStyleFinder::canShareStyleWithElement (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 5 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove check from SharedStyleFinder::canShareStyleWithElement Since we know both elements have the same tag name at this point, they also should return the same for isFormControlElement. So weaken the check to an ASSERT. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M Source/core/css/resolver/SharedStyleFinder.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rwlbuis
PTAL.
6 years, 5 months ago (2014-07-23 21:36:35 UTC) #1
esprehn
lgtm
6 years, 5 months ago (2014-07-23 22:46:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/418573003/1
6 years, 5 months ago (2014-07-23 22:47:43 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-24 04:48:32 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 04:56:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/16844)
6 years, 5 months ago (2014-07-24 04:56:15 UTC) #6
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-07-24 10:17:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/418573003/1
6 years, 5 months ago (2014-07-24 10:18:37 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-24 11:03:31 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 11:54:22 UTC) #10
Message was sent while issue was closed.
Change committed as 178834

Powered by Google App Engine
This is Rietveld 408576698