Source/core/css/resolver/SharedStyleFinder.cpp - Issue 418573003: Remove check from SharedStyleFinder::canShareStyleWithElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/SharedStyleFinder.cpp

Issue 418573003: Remove check from SharedStyleFinder::canShareStyleWithElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/SharedStyleFinder.cpp

diff --git a/Source/core/css/resolver/SharedStyleFinder.cpp b/Source/core/css/resolver/SharedStyleFinder.cpp

index 76f97e0554bb043b5531ef38b00184fdb94228b3..789c7315cea5feb60adbd9b5eade79c0928d9ffb 100644

--- a/Source/core/css/resolver/SharedStyleFinder.cpp

+++ b/Source/core/css/resolver/SharedStyleFinder.cpp

@@ -234,10 +234,7 @@ bool SharedStyleFinder::canShareStyleWithElement(Element& candidate) const

return false;

bool isControl = candidate.isFormControlElement();

- if (isControl != element().isFormControlElement())

- return false;

+ ASSERT(isControl == element().isFormControlElement());

if (isControl && !canShareStyleWithControl(candidate))

return false;

« no previous file with comments | « no previous file | no next file » | no next file with comments »