Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: LayoutTests/fast/repaint/scrollbar-parts.html

Issue 418483004: Fix scrollbar damage accumulation issue (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/repaint/scrollbar-parts.html
diff --git a/LayoutTests/fast/repaint/scrollbar-parts.html b/LayoutTests/fast/repaint/scrollbar-parts.html
new file mode 100644
index 0000000000000000000000000000000000000000..793d631933d160dd66ee2bb049499eb9428a426a
--- /dev/null
+++ b/LayoutTests/fast/repaint/scrollbar-parts.html
@@ -0,0 +1,17 @@
+<!DOCTYPE html>
+<script src="resources/text-based-repaint.js"></script>
+<script>
+function repaintTest() {
+ var child = document.getElementById('child');
+ child.style.width = '150px';
+ child.style.height = '300px';
+}
+runRepaintTest();
Julien - ping for review 2014/07/25 17:20:10 While this works, I would argue to run it off the
Xianzhu 2014/07/25 17:28:25 Done. Also just noticed this might cause flakiness
+</script>
+
+<!-- The scrollbar parts (forward track, thumb and back track) of the container
+ should be properly repainted when the contents change size. -->
Julien - ping for review 2014/07/25 17:20:10 We should dump this into the text output as we are
Xianzhu 2014/07/25 17:28:25 Currently text-based-repaint dump the layer tree o
Julien - ping for review 2014/07/25 20:24:44 I don't think that's a good argument. I am not con
Xianzhu 2014/07/25 20:54:58 Setting font and font size won't work because the
+<div style="width: 100px; height: 100px; overflow: scroll">
+ <div id="child" style="width: 200px; height: 200px"></div>
+</div>
+
« no previous file with comments | « no previous file | LayoutTests/fast/repaint/scrollbar-parts-expected.txt » ('j') | Source/platform/scroll/ScrollableArea.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698