LayoutTests/fast/repaint/scrollbar-parts.html - Issue 418483004: Fix scrollbar damage accumulation issue

Side by Side Diff: LayoutTests/fast/repaint/scrollbar-parts.html

Issue 418483004: Fix scrollbar damage accumulation issue (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add test Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="resources/text-based-repaint.js"></script>

	3 <script>

	4 function repaintTest() {

	5 var child = document.getElementById('child');

	6 child.style.width = '150px';

	7 child.style.height = '300px';

	8 }

	9 runRepaintTest();
	Julien - ping for review 2014/07/25 17:20:10 While this works, I would argue to run it off the While this works, I would argue to run it off the 'load' event as it matches the other code and is more bullet proof if we change how runRepaintTest works. Xianzhu 2014/07/25 17:28:25 Done. Also just noticed this might cause flakiness Show quoted text On 2014/07/25 17:20:10, Julien Chaffraix - PST wrote: > While this works, I would argue to run it off the 'load' event as it matches the > other code and is more bullet proof if we change how runRepaintTest works. Done. Also just noticed this might cause flakiness if load is slow for a big test (a frame may be generated during load).
	10 </script>

	11

	12 <!-- The scrollbar parts (forward track, thumb and back track) of the container

	13 should be properly repainted when the contents change size. -->
	Julien - ping for review 2014/07/25 17:20:10 We should dump this into the text output as we are We should dump this into the text output as we are doing a text dump. Xianzhu 2014/07/25 17:28:25 Currently text-based-repaint dump the layer tree o Show quoted text On 2014/07/25 17:20:10, Julien Chaffraix - PST wrote: > We should dump this into the text output as we are doing a text dump. Currently text-based-repaint dump the layer tree only, not including text in the test. Also the text causes platform rebaselines because of different text sizes and I'd like to avoid that. Julien - ping for review 2014/07/25 20:24:44 I don't think that's a good argument. I am not con Show quoted text On 2014/07/25 17:28:25, Xianzhu wrote: > On 2014/07/25 17:20:10, Julien Chaffraix - PST wrote: > > We should dump this into the text output as we are doing a text dump. > > Currently text-based-repaint dump the layer tree only, not including text in the > test. Also the text causes platform rebaselines because of different text sizes > and I'd like to avoid that. I don't think that's a good argument. I am not concerned about the text output here but someone trying to understand what's going wrong if this test output changes. If you set the font and font size explicitly that should prevent the font issue. Xianzhu 2014/07/25 20:54:58 Setting font and font size won't work because the Show quoted text On 2014/07/25 20:24:44, Julien Chaffraix - PST wrote: > On 2014/07/25 17:28:25, Xianzhu wrote: > > On 2014/07/25 17:20:10, Julien Chaffraix - PST wrote: > > > We should dump this into the text output as we are doing a text dump. > > > > Currently text-based-repaint dump the layer tree only, not including text in > the > > test. Also the text causes platform rebaselines because of different text > sizes > > and I'd like to avoid that. > > I don't think that's a good argument. I am not concerned about the text output > here but someone trying to understand what's going wrong if this test output > changes. If you set the font and font size explicitly that should prevent the > font issue. Setting font and font size won't work because the physical font metrics differences, but 'div style="height: xxx"' should work. Will use the method in later changes. Might also change existing tests to reduce platform rebaselines.
	14 <div style="width: 100px; height: 100px; overflow: scroll">

	15 <div id="child" style="width: 200px; height: 200px"></div>

	16 </div>

	17

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/repaint/scrollbar-parts-expected.txt » ('j') | Source/platform/scroll/ScrollableArea.h » ('J')