Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3104)

Unified Diff: device/bluetooth/bluetooth_device.h

Issue 418483003: device/bluetooth: Move GATT observer methods to BluetoothAdapter::Observer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/bluetooth/bluetooth_adapter_chromeos.cc ('k') | device/bluetooth/bluetooth_device_chromeos.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluetooth_device.h
diff --git a/device/bluetooth/bluetooth_device.h b/device/bluetooth/bluetooth_device.h
index 582caf34fd24a57be1f85cdc7f987e8931e5e7aa..4557f3b5e0b795ca221ddea8f3ceaf08603c94e2 100644
--- a/device/bluetooth/bluetooth_device.h
+++ b/device/bluetooth/bluetooth_device.h
@@ -81,26 +81,6 @@ class BluetoothDevice {
ERROR_UNSUPPORTED_DEVICE
};
- // Interface for observing changes from bluetooth devices.
- class Observer {
- public:
- virtual ~Observer() {}
-
- // Called when a new GATT service |service| is added to the device |device|,
- // as the service is received from the device. Don't cache |service|. Store
- // its identifier instead (i.e. BluetoothGattService::GetIdentifier).
- virtual void GattServiceAdded(BluetoothDevice* device,
- BluetoothGattService* service) {}
-
- // Called when the GATT service |service| is removed from the device
- // |device|. This can happen if the attribute database of the remote device
- // changes or when |device| gets removed.
- virtual void GattServiceRemoved(BluetoothDevice* device,
- BluetoothGattService* service) {}
-
- // TODO(keybuk): add observers for pairing and connection.
- };
-
// Interface for negotiating pairing of bluetooth devices.
class PairingDelegate {
public:
@@ -190,12 +170,6 @@ class BluetoothDevice {
virtual ~BluetoothDevice();
- // Adds and removes observers for events on this Bluetooth device. If
- // monitoring multiple devices, check the |device| parameter of the observer
- // methods to determine which device is issuing the event.
- virtual void AddObserver(Observer* observer) = 0;
- virtual void RemoveObserver(Observer* observer) = 0;
-
// Returns the Bluetooth class of the device, used by GetDeviceType()
// and metrics logging,
virtual uint32 GetBluetoothClass() const = 0;
« no previous file with comments | « device/bluetooth/bluetooth_adapter_chromeos.cc ('k') | device/bluetooth/bluetooth_device_chromeos.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698