Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 418483003: device/bluetooth: Move GATT observer methods to BluetoothAdapter::Observer. (Closed)

Created:
6 years, 5 months ago by armansito
Modified:
6 years, 4 months ago
Reviewers:
keybuk
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, rpaquay
Project:
chromium
Visibility:
Public.

Description

device/bluetooth: Move GATT observer methods to BluetoothAdapter::Observer. This CL merges BluetoothDevice::Observer and BluetoothGattService::Observer interfaces to BluetoothAdapter::Observer. This makes adding and removing observers much cleaner for users of the library. It also removes the problem of adding observers on platforms where instances are temporary and aren't kept alive for long. BUG=384664 TEST=device_unittests; browser_tests:BluetoothLowEnergyApiTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+621 lines, -671 lines) Patch
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc View 35 chunks +164 lines, -163 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h View 3 chunks +12 lines, -24 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc View 13 chunks +40 lines, -69 lines 0 comments Download
M device/bluetooth/bluetooth_adapter.h View 2 chunks +78 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.h View 2 chunks +24 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_chromeos.cc View 2 chunks +114 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device.h View 2 chunks +0 lines, -26 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.h View 3 chunks +0 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.cc View 3 chunks +9 lines, -18 lines 0 comments Download
M device/bluetooth/bluetooth_device_mac.h View 2 chunks +0 lines, -7 lines 0 comments Download
M device/bluetooth/bluetooth_device_mac.mm View 1 chunk +0 lines, -12 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.h View 2 chunks +0 lines, -7 lines 0 comments Download
M device/bluetooth/bluetooth_device_win.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 41 chunks +156 lines, -200 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_service.h View 1 chunk +0 lines, -76 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.h View 3 chunks +1 line, -8 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.cc View 8 chunks +21 lines, -35 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_device.h View 1 chunk +0 lines, -2 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_gatt_service.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
armansito
rpaquay@: cc'd FYI
6 years, 5 months ago (2014-07-23 18:24:06 UTC) #1
keybuk
lgtm this looks much cleaner!
6 years, 4 months ago (2014-07-29 17:31:53 UTC) #2
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 4 months ago (2014-07-29 19:10:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/418483003/1
6 years, 4 months ago (2014-07-29 19:12:12 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 01:21:42 UTC) #5
Message was sent while issue was closed.
Change committed as 286371

Powered by Google App Engine
This is Rietveld 408576698