Pepper: Stop using SRPC for irt_open_resource().

ppapi/native_client/src/trusted/plugin/service_runtime.cc

Index: ppapi/native_client/src/trusted/plugin/service_runtime.cc
diff --git a/ppapi/native_client/src/trusted/plugin/service_runtime.cc b/ppapi/native_client/src/trusted/plugin/service_runtime.cc
index ffce56320dedd85df0dc9ae4d7f82fa6291d2142..3e198e7e6900a062b800cc7aec8754a6c93ed1c3 100644
--- a/ppapi/native_client/src/trusted/plugin/service_runtime.cc
+++ b/ppapi/native_client/src/trusted/plugin/service_runtime.cc
@@ -176,6 +176,13 @@ void PluginReverseInterface::OpenManifestEntry_MainThreadContinuation(
   UNREFERENCED_PARAMETER(err);
   // CallOnMainThread continuations always called with err == PP_OK.
 
+  // This method should only ever be called from the PNaCl translator, as the
+  // IRT is not available there.
+  if (service_runtime_->main_service_runtime()) {
+    NaClLog(LOG_ERROR,

[Mark Seaborn, 2014/08/28 21:33:49]

Can you make this reject the request, as a security-hardening measure, so that
we're not exposing the old SRPC-based manifest file code path to the web?

Or would it be better to reject the request earlier, in
PluginReverseInterface::OpenManifestEntry()?

[teravest, 2014/09/04 22:13:30]

Sure, I've changed this to reject the request (and do so earlier, in
OpenManifestEntry). Good call.

+            "OpenManifestEntry should only be used by PNaCl translator.\n");
+  }
+
   NaClLog(4, "Entered OpenManifestEntry_MainThreadContinuation\n");
 
   // Because p is owned by the callback of this invocation, so it is necessary