Pepper: Stop using SRPC for irt_open_resource().

ppapi/native_client/src/trusted/plugin/service_runtime.cc

 /*
  * Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #define NACL_LOG_MODULE_NAME "Plugin_ServiceRuntime"
 
 #include "ppapi/native_client/src/trusted/plugin/service_runtime.h"
 
@@ skipping 158 matching lines @@
 // OpenManifestEntry() is waiting on a condvar for this continuation to
 // complete.  We Broadcast and awaken OpenManifestEntry() whenever we are done
 // either here, or in a later MainThreadContinuation step, if there are
 // multiple steps.
 void PluginReverseInterface::OpenManifestEntry_MainThreadContinuation(
     OpenManifestEntryResource* p,
     int32_t err) {
   UNREFERENCED_PARAMETER(err);
   // CallOnMainThread continuations always called with err == PP_OK.
 
+  // This method should only ever be called from the PNaCl translator, as the
+  // IRT is not available there.
+  if (service_runtime_->main_service_runtime()) {
+    NaClLog(LOG_ERROR,

[Mark Seaborn, 2014/08/28 21:33:49]

Can you make this reject the request, as a security-hardening measure, so that
we're not exposing the old SRPC-based manifest file code path to the web?

Or would it be better to reject the request earlier, in
PluginReverseInterface::OpenManifestEntry()?

[teravest, 2014/09/04 22:13:30]

Sure, I've changed this to reject the request (and do so earlier, in
OpenManifestEntry). Good call.

+            "OpenManifestEntry should only be used by PNaCl translator.\n");
+  }
+
   NaClLog(4, "Entered OpenManifestEntry_MainThreadContinuation\n");
 
   // Because p is owned by the callback of this invocation, so it is necessary
   // to create another instance.
   OpenManifestEntryResource* open_cont = new OpenManifestEntryResource(*p);
   pp::CompletionCallback stream_cc = WeakRefNewCallback(
       anchor_,
       this,
       &PluginReverseInterface::StreamAsFile_MainThreadContinuation,
       open_cont);
@@ skipping 388 matching lines @@
     reverse_service_->Unref();
 
   rev_interface_->Unref();
 
   anchor_->Unref();
   NaClCondVarDtor(&cond_);
   NaClMutexDtor(&mu_);
 }
 
 }  // namespace plugin