Issue 418393002: Revert 285458 "Disable exceptions on Windows in all builds (take 3)"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 418393002: Revert 285458 "Disable exceptions on Windows in all builds (take 3)" (Closed)

Created:
6 years, 5 months ago by zhaoqin

Modified:
6 years, 5 months ago

Reviewers:
hans

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 285458 "Disable exceptions on Windows in all builds (take 3)" BUG=397465 > Disable exceptions on Windows in all builds (take 3) > > They were previously enabled in shared_library builds for historical reasons. > > This change is relevant for Clang, which currently doesn't support exceptions > on Windows. > > Previous attemps failed due to: > - chrome_elf_unittests on x64 (crbug.com/396244) > Fixed in Chromium r285377. > > - blink_platform_unittests:DateTimeFormatTest.CommonPattern et al. > Fixed in Blink r176189 > > BUG=82385 > TBR=thakis > > Review URL: https://codereview.chromium.org/420593002 TBR=hans@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285614

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	trunk/src/build/common.gypi	View		3 chunks	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zhaoqin

6 years, 5 months ago (2014-07-25 17:33:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r285614 (tree was closed).

Expand Messages | Collapse Messages