Issue 420593002: Disable exceptions on Windows in all builds (take 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 420593002: Disable exceptions on Windows in all builds (take 3) (Closed)

Created:
6 years, 5 months ago by hans

Modified:
6 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable exceptions on Windows in all builds (take 3) They were previously enabled in shared_library builds for historical reasons. This change is relevant for Clang, which currently doesn't support exceptions on Windows. Previous attemps failed due to: - chrome_elf_unittests on x64 (crbug.com/396244) Fixed in Chromium r285377. - blink_platform_unittests:DateTimeFormatTest.CommonPattern et al. Fixed in Blink r176189 BUG=82385 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285458