Issue 418343002: Revert 178911 "Revert 178848 "[DevTools] Make toolbar counters d..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 418343002: Revert 178911 "Revert 178848 "[DevTools] Make toolbar counters d..." (Closed)

Created:
6 years, 5 months ago by dgozman

Modified:
6 years, 5 months ago

Reviewers:
haraken

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 178911 "Revert 178848 "[DevTools] Make toolbar counters d..." Broken test is incorrect and was disabled. > Revert 178848 "[DevTools] Make toolbar counters declarative." > > This CL or r178850 broke the following browser tests. > http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/3288 > > Let me revert the two CLs at the moment. > > > > [DevTools] Make toolbar counters declarative. > > > > This includes error-warning and devices counters. > > > > BUG=none > > > > Review URL: https://codereview.chromium.org/408853002 > > TBR=dgozman@chromium.org > > Review URL: https://codereview.chromium.org/416983006 R=haraken@chromium.org TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178930

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+226 lines, -122 lines)			Patch
M	trunk/Source/devtools/front_end/components/DockController.js	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/Source/devtools/front_end/components/InspectElementModeController.js	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/Source/devtools/front_end/components/InspectorView.js	View	4 chunks	+19 lines, -63 lines	0 comments	Download
M	trunk/Source/devtools/front_end/inspectorStyle.css	View	3 chunks	+12 lines, -14 lines	0 comments	Download
M	trunk/Source/devtools/front_end/main/AdvancedApp.js	View	3 chunks	+46 lines, -3 lines	0 comments	Download
M	trunk/Source/devtools/front_end/main/Main.js	View	5 chunks	+32 lines, -21 lines	0 comments	Download
M	trunk/Source/devtools/front_end/main/ScreencastApp.js	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/Source/devtools/front_end/main/module.json	View	1 chunk	+24 lines, -6 lines	0 comments	Download
M	trunk/Source/devtools/front_end/settings/module.json	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/Source/devtools/front_end/ui/StatusBarButton.js	View	2 chunks	+82 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r178930.