Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 416983006: Revert 178848 "[DevTools] Make toolbar counters declarative." (Closed)

Created:
6 years, 4 months ago by haraken
Modified:
6 years, 4 months ago
Reviewers:
dgozman
CC:
blink-reviews
Visibility:
Public.

Description

Revert 178848 "[DevTools] Make toolbar counters declarative." This CL or r178850 broke the following browser tests. http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/3288 Let me revert the two CLs at the moment. > [DevTools] Make toolbar counters declarative. > > This includes error-warning and devices counters. > > BUG=none > > Review URL: https://codereview.chromium.org/408853002 TBR=dgozman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -226 lines) Patch
M trunk/Source/devtools/front_end/components/DockController.js View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/devtools/front_end/components/InspectElementModeController.js View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/devtools/front_end/components/InspectorView.js View 4 chunks +63 lines, -19 lines 0 comments Download
M trunk/Source/devtools/front_end/inspectorStyle.css View 3 chunks +14 lines, -12 lines 0 comments Download
M trunk/Source/devtools/front_end/main/AdvancedApp.js View 3 chunks +3 lines, -46 lines 0 comments Download
M trunk/Source/devtools/front_end/main/Main.js View 5 chunks +21 lines, -32 lines 0 comments Download
M trunk/Source/devtools/front_end/main/ScreencastApp.js View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/Source/devtools/front_end/main/module.json View 1 chunk +6 lines, -24 lines 0 comments Download
M trunk/Source/devtools/front_end/settings/module.json View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/devtools/front_end/ui/StatusBarButton.js View 2 chunks +4 lines, -82 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
6 years, 4 months ago (2014-07-25 08:37:00 UTC) #1
haraken
6 years, 4 months ago (2014-07-25 08:37:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r178911.

Powered by Google App Engine
This is Rietveld 408576698