content/browser/renderer_host/render_widget_host_view_browsertest.cc - Issue 418283003: "Buttery Smooth" Tab Capture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_browsertest.cc

Issue 418283003: "Buttery Smooth" Tab Capture. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Now pixel-weighted. Lots of add'l unit tests. (rebased against ToT) Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/capture/video_capture_oracle_unittest.cc ('K') | « content/browser/renderer_host/render_widget_host_view_aura_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_browsertest.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_browsertest.cc b/content/browser/renderer_host/render_widget_host_view_browsertest.cc

index 2db559701c9033e2964008de3cc14edbafa70ad5..a1ffa149078c0beb4656ae765f54003d38c72f68 100644

--- a/content/browser/renderer_host/render_widget_host_view_browsertest.cc

+++ b/content/browser/renderer_host/render_widget_host_view_browsertest.cc

@@ -247,7 +247,8 @@ class FakeFrameSubscriber : public RenderWidgetHostViewFrameSubscriber {

: callback_(callback) {

}

- virtual bool ShouldCaptureFrame(base::TimeTicks present_time,

+ virtual bool ShouldCaptureFrame(const gfx::Rect& damage_rect,

+ base::TimeTicks present_time,

scoped_refptr<media::VideoFrame>* storage,

DeliverFrameCallback* callback) OVERRIDE {

// Only allow one frame capture to be made. Otherwise, the compositor could