Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 418243003: [DevTools] Move DispatchOnDevToolsFrontend to embedder. (Closed)

Created:
6 years, 4 months ago by dgozman
Modified:
6 years, 4 months ago
Reviewers:
jam, pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move DispatchOnDevToolsFrontend to embedder. We already have a way to send message via ExecuteJavaScript, no need for another mechanism. BUG=398046 TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288027

Patch Set 1 #

Total comments: 2

Patch Set 2 : moved debugging code to frontend #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -45 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/devtools/devtools_frontend_host_impl.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/devtools/devtools_frontend_host_impl.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M content/public/browser/devtools_frontend_host.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/devtools/devtools_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/devtools/devtools_client.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
dgozman
Take a look please. This is a follow-up to https://codereview.chromium.org/427143003/.
6 years, 4 months ago (2014-07-31 14:06:59 UTC) #1
pfeldman
https://codereview.chromium.org/418243003/diff/1/chrome/browser/devtools/devtools_ui_bindings.cc File chrome/browser/devtools/devtools_ui_bindings.cc (right): https://codereview.chromium.org/418243003/diff/1/chrome/browser/devtools/devtools_ui_bindings.cc#newcode807 chrome/browser/devtools/devtools_ui_bindings.cc:807: " if (!window.__callClientFunction) window.__callClientFunction = [];" Should we do ...
6 years, 4 months ago (2014-07-31 14:25:08 UTC) #2
dgozman
PTAL https://codereview.chromium.org/418243003/diff/1/chrome/browser/devtools/devtools_ui_bindings.cc File chrome/browser/devtools/devtools_ui_bindings.cc (right): https://codereview.chromium.org/418243003/diff/1/chrome/browser/devtools/devtools_ui_bindings.cc#newcode807 chrome/browser/devtools/devtools_ui_bindings.cc:807: " if (!window.__callClientFunction) window.__callClientFunction = [];" On 2014/07/31 ...
6 years, 4 months ago (2014-07-31 15:09:32 UTC) #3
pfeldman
lgtm
6 years, 4 months ago (2014-07-31 16:30:24 UTC) #4
dgozman
John, could you please take a look at content/public?
6 years, 4 months ago (2014-08-01 19:49:06 UTC) #5
dgozman
On 2014/08/01 19:49:06, dgozman wrote: > John, could you please take a look at content/public? ...
6 years, 4 months ago (2014-08-05 07:53:30 UTC) #6
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-05 07:53:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/418243003/20001
6 years, 4 months ago (2014-08-05 07:56:08 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 10:46:03 UTC) #9
commit-bot: I haz the power
Change committed as 287514
6 years, 4 months ago (2014-08-05 11:38:34 UTC) #10
kouhei (in TOK)
A revert of this CL has been created in https://codereview.chromium.org/444633003/ by kouhei@chromium.org. The reason for ...
6 years, 4 months ago (2014-08-05 17:40:16 UTC) #11
dgozman
On 2014/08/05 17:40:16, kouhei wrote: > A revert of this CL has been created in ...
6 years, 4 months ago (2014-08-06 16:11:10 UTC) #12
jam
lgtm
6 years, 4 months ago (2014-08-07 05:48:18 UTC) #13
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-07 07:47:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/418243003/40001
6 years, 4 months ago (2014-08-07 07:48:26 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 11:04:53 UTC) #16
Message was sent while issue was closed. 
Change committed as 288027

Powered by Google App Engine
This is Rietveld 408576698