[DevTools] Move DispatchOnDevToolsFrontend to embedder.

chrome/browser/devtools/devtools_ui_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/devtools_ui_bindings.h"
 
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 391 matching lines @@
 
 void DevToolsUIBindings::HandleMessageFromDevToolsFrontendToBackend(
     const std::string& message) {
   content::DevToolsManager::GetInstance()->DispatchOnInspectorBackend(
       this, message);
 }
 
 // content::DevToolsClientHost implementation ---------------------------------
 void DevToolsUIBindings::DispatchOnInspectorFrontend(
     const std::string& message) {
-  if (frontend_host_)
-    frontend_host_->DispatchOnDevToolsFrontend(message);
+  base::StringValue message_value(message);
+  CallClientFunction("InspectorFrontendAPI.dispatchMessage",
+                     &message_value, NULL, NULL);
 }
 
 void DevToolsUIBindings::InspectedContentsClosing() {
   delegate_->InspectedContentsClosing();
 }
 
 void DevToolsUIBindings::ReplacedWithAnotherClient() {
 }
 
 // DevToolsEmbedderMessageDispatcher::Delegate implementation -----------------
@@ skipping 365 matching lines @@
     params.append(json);
     if (arg2) {
       base::JSONWriter::Write(arg2, &json);
       params.append(", " + json);
       if (arg3) {
         base::JSONWriter::Write(arg3, &json);
         params.append(", " + json);
       }
     }
   }
-  base::string16 javascript =
-      base::UTF8ToUTF16(function_name + "(" + params + ");");
+
+  std::string code = function_name + "(" + params + ");";
+#if defined(DEBUG_DEVTOOLS)
+  // To debug DevTools itself, we should postpone incoming messages while
+  // paused in debugger. To achieve this, we wrap all calls in setTimeout
+  // and rely on the fact that timers are suspended when debugging.
+  code = "(function() {"
+         "  if (!window.__callClientFunction) window.__callClientFunction = [];"

[pfeldman, 2014/07/31 14:25:08]

Should we do this on the front-end side instead?

[dgozman, 2014/07/31 15:09:32]

Done.

+         ""
+         "  function executeCall() {" + code + "}"
+         ""
+         "  function onTimeout() {"
+         "    while (window.__callClientFunction.length) {"
+         "      window.__callClientFunction.shift()();"
+         "    }"
+         "  }"
+         ""
+         "  window.__callClientFunction.push(executeCall);"
+         "  if (window.__callClientFunction.length == 1)"
+         "    window.setTimeout(onTimeout, 0);"
+         "})();";
+#endif  // defined(DEBUG_DEVTOOLS)
+
+  base::string16 javascript = base::UTF8ToUTF16(code);
   web_contents_->GetMainFrame()->ExecuteJavaScript(javascript);
 }
 
 void DevToolsUIBindings::DocumentOnLoadCompletedInMainFrame() {
   // Call delegate first - it seeds importants bit of information.
   delegate_->OnLoadCompleted();
 
   UpdateTheme();
   AddDevToolsExtensionsToClient();
 }