Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 418133008: Telemetry: Fix inbox_app.html?slide_drawer of key_silk_cases. (Closed)

Created:
6 years, 5 months ago by Dominik Grewe
Modified:
6 years, 4 months ago
Reviewers:
tonyg, ernstm
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Fix inbox_app.html?slide_drawer of key_silk_cases. This page toggles the drawer as part of its navigate steps. It then waits until the navigation drawer is active before continuing. The navigation drawer is active, however, as soon as it starts moving, so it doesn't mean that the drawer is in its final position. This CL adds an additional check to make sure that the drawer is actually fully out before continuing. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/perf/page_sets/key_silk_cases.py View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dominik Grewe
This hasn't been a problem up to now, because we always have an (unintentional) gap ...
6 years, 5 months ago (2014-07-25 12:33:44 UTC) #1
tonyg
lgtm
6 years, 5 months ago (2014-07-25 13:55:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominikg@chromium.org/418133008/1
6 years, 5 months ago (2014-07-25 13:57:04 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-07-25 17:13:40 UTC) #4
Message was sent while issue was closed.
Change committed as 285608

Powered by Google App Engine
This is Rietveld 408576698