tools/perf/page_sets/key_silk_cases.py - Issue 418133008: Telemetry: Fix inbox_app.html?slide_drawer of key_silk_cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/key_silk_cases.py

Issue 418133008: Telemetry: Fix inbox_app.html?slide_drawer of key_silk_cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/key_silk_cases.py

diff --git a/tools/perf/page_sets/key_silk_cases.py b/tools/perf/page_sets/key_silk_cases.py

index 4e9941f5840ae6579e4625ab943bc277287351c2..c8066965b6edb74f34cdf657374af653b99cf3a1 100644

--- a/tools/perf/page_sets/key_silk_cases.py

+++ b/tools/perf/page_sets/key_silk_cases.py

@@ -363,8 +363,10 @@ class Page19(KeySilkCasesPage):

interaction.End()

interaction = action_runner.BeginInteraction('Wait', is_smooth=True)

- action_runner.WaitForJavaScriptCondition(

- 'document.getElementById("nav-drawer").active')

+ action_runner.WaitForJavaScriptCondition('''

+ document.getElementById("nav-drawer").active &&

+ document.getElementById("nav-drawer").children[0]

+ .getBoundingClientRect().left == 0''')

interaction.End()

def RunNavigateSteps(self, action_runner):

« no previous file with comments | « no previous file | no next file » | no next file with comments »