Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: chrome/browser/resources/gaia_auth/main.js

Issue 418043002: Add test for showing confirmation dialog for unsecure signin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/gaia_auth/main.js
diff --git a/chrome/browser/resources/gaia_auth/main.js b/chrome/browser/resources/gaia_auth/main.js
index 1c61a2448150e9d110e5aa9ae4682331e695b599..ba48c65dc9049f2dc8cb453d754480286497b3f8 100644
--- a/chrome/browser/resources/gaia_auth/main.js
+++ b/chrome/browser/resources/gaia_auth/main.js
@@ -428,6 +428,11 @@ Authenticator.prototype = {
this.maybeCompleteSAMLLogin_();
}
} else if (msg.method == 'confirmLogin' && this.isInternalMessage_(e)) {
+ // In the desktop mode, Chrome needs to wait for extra info such as
+ // session index from the background JS.
+ if (this.desktopMode_)
+ return;
+
if (this.attemptToken_ == msg.attemptToken)
this.onConfirmLogin_();
else

Powered by Google App Engine
This is Rietveld 408576698