Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2394)

Unified Diff: chrome/browser/signin/signin_promo.cc

Issue 418043002: Add test for showing confirmation dialog for unsecure signin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/signin_promo.cc
diff --git a/chrome/browser/signin/signin_promo.cc b/chrome/browser/signin/signin_promo.cc
index 972178d12f835c4dca04264d6952934ad95c5943..55c30955aed64ba72229ba9842c12c17e064bc31 100644
--- a/chrome/browser/signin/signin_promo.cc
+++ b/chrome/browser/signin/signin_promo.cc
@@ -163,8 +163,15 @@ void SetUserSkippedPromo(Profile* profile) {
}
GURL GetLandingURL(const char* option, int value) {
- const std::string& locale = g_browser_process->GetApplicationLocale();
- std::string url = base::StringPrintf(kSignInLandingUrlPrefix, locale.c_str());
+ std::string url;
+ if (switches::IsEnableWebBasedSignin()) {
+ const std::string& locale = g_browser_process->GetApplicationLocale();
+ url = base::StringPrintf(kSignInLandingUrlPrefix, locale.c_str());
+ } else {
+ const char kGaiaExtSuccessURLPrefix[] =
+ "chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik/success.html";
Roger Tawa OOO till Jul 10th 2014/07/28 14:27:50 Put this in header file? Also used in oobe_ui.cc,
guohui 2014/08/07 19:53:34 Done.
+ url = kGaiaExtSuccessURLPrefix;
+ }
base::StringAppendF(&url, "?%s=%d", option, value);
return GURL(url);
}

Powered by Google App Engine
This is Rietveld 408576698