Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 417823002: Merge 178313 "Add monospace-specific fallback for Hebrew and Ara..." (Closed)

Created:
6 years, 5 months ago by scottmg
Modified:
6 years, 5 months ago
Reviewers:
scottmg
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

Merge 178313 "Add monospace-specific fallback for Hebrew and Ara..." > Add monospace-specific fallback for Hebrew and Arabic from Consolas->Courier New > > Potential problems: > > - Might break Arabic/Hebrew fallbacks if there are glyphs in Tahoma that aren't in Consolas or Courier New. I used charmap to inspect the unicode ranges that Wikipedia lists under http://en.wikipedia.org/wiki/Hebrew_alphabet and http://en.wikipedia.org/wiki/Arabic_alphabet and I believe Courier New has a full set. So I think this is OK. > > - Might be necessary for other scripts too, but I guess we can add more hackery for that if necessary. > > - Kind of ugly. > > R=eae@chromium.org > BUG=388087 > > Review URL: https://codereview.chromium.org/399533002 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M Source/platform/fonts/win/FontFallbackWin.cpp View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
6 years, 5 months ago (2014-07-23 22:05:47 UTC) #1
scottmg
6 years, 5 months ago (2014-07-23 22:06:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r178786.

Powered by Google App Engine
This is Rietveld 408576698