Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 399533002: Add monospace-specific fallback for Hebrew and Arabic from Consolas->Courier New (Closed)

Created:
6 years, 5 months ago by scottmg
Modified:
6 years, 5 months ago
Reviewers:
eae
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis, cpu_(ooo_6.6-7.5)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add monospace-specific fallback for Hebrew and Arabic from Consolas->Courier New Potential problems: - Might break Arabic/Hebrew fallbacks if there are glyphs in Tahoma that aren't in Consolas or Courier New. I used charmap to inspect the unicode ranges that Wikipedia lists under http://en.wikipedia.org/wiki/Hebrew_alphabet and http://en.wikipedia.org/wiki/Arabic_alphabet and I believe Courier New has a full set. So I think this is OK. - Might be necessary for other scripts too, but I guess we can add more hackery for that if necessary. - Kind of ugly. R=eae@chromium.org BUG=388087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M Source/platform/fonts/win/FontFallbackWin.cpp View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
6 years, 5 months ago (2014-07-16 14:45:56 UTC) #1
eae
Makes sense, we could also consider a more generic two-staged fallback chain (monospace > consolas ...
6 years, 5 months ago (2014-07-16 14:51:47 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 5 months ago (2014-07-16 15:19:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/399533002/1
6 years, 5 months ago (2014-07-16 15:20:30 UTC) #4
scottmg
The CQ bit was unchecked by scottmg@chromium.org
6 years, 5 months ago (2014-07-17 00:56:42 UTC) #5
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 5 months ago (2014-07-17 00:56:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/399533002/1
6 years, 5 months ago (2014-07-17 00:56:55 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 04:06:30 UTC) #8
Message was sent while issue was closed.
Change committed as 178313

Powered by Google App Engine
This is Rietveld 408576698