Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 417603002: Remove duplicate extensions unit tests from chrome_tests_unit.gypi (Closed)

Created:
6 years, 5 months ago by James Cook
Modified:
6 years, 5 months ago
Reviewers:
tfarina, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Remove duplicate extensions unit tests from chrome_tests_unit.gypi Extensions unit tests originally ran as part of Chrome's unit_tests suite. We have introduced a extensions_unittests target which is now running on trybots, CQ and main waterfall. It started with duplicates of tests in chrome_tests_unit.gypi (so we wouldn't lose coverage). Now that extensions_unittests is running everywhere we can remove the duplicate test entries. BUG=348066 TEST=unit_tests extensions_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285069

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M chrome/chrome_tests_unit.gypi View 2 chunks +0 lines, -15 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
James Cook
yoz, PTAL (I need an extensions/ owner.) tfarina, FYI
6 years, 5 months ago (2014-07-23 16:55:48 UTC) #1
Yoyo Zhou
LGTM
6 years, 5 months ago (2014-07-23 17:25:37 UTC) #2
tfarina
I thought you were you going to leave the honor to me. Since I did ...
6 years, 5 months ago (2014-07-23 17:37:28 UTC) #3
James Cook
On 2014/07/23 17:37:28, tfarina wrote: > I thought you were you going to leave the ...
6 years, 5 months ago (2014-07-23 18:31:39 UTC) #4
tfarina
On Wed, Jul 23, 2014 at 3:31 PM, <jamescook@chromium.org> wrote: > On 2014/07/23 17:37:28, tfarina ...
6 years, 5 months ago (2014-07-23 18:36:26 UTC) #5
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 5 months ago (2014-07-23 18:40:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/417603002/1
6 years, 5 months ago (2014-07-23 18:41:54 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 22:55:23 UTC) #8
Message was sent while issue was closed.
Change committed as 285069

Powered by Google App Engine
This is Rietveld 408576698