Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: extensions/extensions.gyp

Issue 417603002: Remove duplicate extensions unit tests from chrome_tests_unit.gypi (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/extensions.gyp
diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp
index 7c3f1442b76c78599668798c829c8b8e330db1e9..a394eb3f8e1dae07253aa9f3a94a2a5f63025254 100644
--- a/extensions/extensions.gyp
+++ b/extensions/extensions.gyp
@@ -689,12 +689,9 @@
'msvs_disabled_warnings': [ 4267, ],
},
{
- # TODO(tfarina): Our plan is to build and run this target on Chromium bots
- # (TS, CQ, Waterfall). First we will get this target passing all tests,
- # after that we will start the work on buildbot to get this running there.
- # When we consider this stable in the bots, we can go to unit_tests target
- # and remove the duplicated entries from there, otherwise if we just
- # remove them right now we would be losing coverage.
+ # TODO(tfarina): Many extension unit tests run as part of Chrome's
+ # unit_tests target. They should be moved here, which may require some
+ # refactoring (ExtensionsBrowserClient, TestingProfile, etc.).
# http://crbug.com/348066
'target_name': 'extensions_unittests',
'type': 'executable',
« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698