chrome/browser/component_updater/test/component_updater_service_unittest.cc - Issue 417453002: Disable all the tests that are flaking more than 5% on Linux builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/test/component_updater_service_unittest.cc

Issue 417453002: Disable all the tests that are flaking more than 5% on Linux builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/process/process_metrics_unittest.cc ('k') | chrome/browser/extensions/api/app_window/app_window_apitest.cc » ('j') | chrome/browser/ssl/ssl_browser_tests.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/test/component_updater_service_unittest.cc

diff --git a/chrome/browser/component_updater/test/component_updater_service_unittest.cc b/chrome/browser/component_updater/test/component_updater_service_unittest.cc

index 29e869cfef69fe5858a9d17afac7f22b6e02e385..d79918f7ca4f26553f8f9d45098f7d3729dabbb2 100644

--- a/chrome/browser/component_updater/test/component_updater_service_unittest.cc

+++ b/chrome/browser/component_updater/test/component_updater_service_unittest.cc

@@ -459,7 +459,13 @@ TEST_F(ComponentUpdaterTest, ProdVersionCheck) {

// nothing happens.

// - We make an on demand call.

// - This triggers a second loop, which has a reply that triggers an install.

-TEST_F(ComponentUpdaterTest, OnDemandUpdate) {

+#if defined(OS_LINUX)

+// http://crbug.com/396488

+#define MAYBE_OnDemandUpdate DISABLED_OnDemandUpdate

+#else

+#define MAYBE_OnDemandUpdate OnDemandUpdate

+#endif

+TEST_F(ComponentUpdaterTest, MAYBE_OnDemandUpdate) {

MockServiceObserver observer;

{

InSequence seq;