Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: chrome/browser/component_updater/test/component_updater_service_unittest.cc

Issue 417453002: Disable all the tests that are flaking more than 5% on Linux builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "chrome/browser/component_updater/test/component_updater_service_unitte st.h" 7 #include "chrome/browser/component_updater/test/component_updater_service_unitte st.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 452
453 component_updater()->Stop(); 453 component_updater()->Stop();
454 } 454 }
455 455
456 // Test that a update check due to an on demand call can cause installs. 456 // Test that a update check due to an on demand call can cause installs.
457 // Here is the timeline: 457 // Here is the timeline:
458 // - First loop: we return a reply that indicates no update, so 458 // - First loop: we return a reply that indicates no update, so
459 // nothing happens. 459 // nothing happens.
460 // - We make an on demand call. 460 // - We make an on demand call.
461 // - This triggers a second loop, which has a reply that triggers an install. 461 // - This triggers a second loop, which has a reply that triggers an install.
462 TEST_F(ComponentUpdaterTest, OnDemandUpdate) { 462 #if defined(OS_LINUX)
463 // http://crbug.com/396488
464 #define MAYBE_OnDemandUpdate DISABLED_OnDemandUpdate
465 #else
466 #define MAYBE_OnDemandUpdate OnDemandUpdate
467 #endif
468 TEST_F(ComponentUpdaterTest, MAYBE_OnDemandUpdate) {
463 MockServiceObserver observer; 469 MockServiceObserver observer;
464 { 470 {
465 InSequence seq; 471 InSequence seq;
466 EXPECT_CALL(observer, 472 EXPECT_CALL(observer,
467 OnEvent(ServiceObserver::COMPONENT_UPDATER_STARTED, "")) 473 OnEvent(ServiceObserver::COMPONENT_UPDATER_STARTED, ""))
468 .Times(1); 474 .Times(1);
469 EXPECT_CALL(observer, 475 EXPECT_CALL(observer,
470 OnEvent(ServiceObserver::COMPONENT_NOT_UPDATED, 476 OnEvent(ServiceObserver::COMPONENT_NOT_UPDATED,
471 "abagagagagagagagagagagagagagagag")) 477 "abagagagagagagagagagagagagagagag"))
472 .Times(1); 478 .Times(1);
(...skipping 1017 matching lines...) Expand 10 before | Expand all | Expand 10 after
1490 component_updater()->RemoveObserver(&observer2); 1496 component_updater()->RemoveObserver(&observer2);
1491 1497
1492 test_configurator()->SetLoopCount(1); 1498 test_configurator()->SetLoopCount(1);
1493 component_updater()->Start(); 1499 component_updater()->Start();
1494 RunThreads(); 1500 RunThreads();
1495 1501
1496 component_updater()->Stop(); 1502 component_updater()->Stop();
1497 } 1503 }
1498 1504
1499 } // namespace component_updater 1505 } // namespace component_updater
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698