Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 417453002: Disable all the tests that are flaking more than 5% on Linux builders. (Closed)

Created:
6 years, 5 months ago by jam
Modified:
6 years, 4 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, hguihot+watch_chromium.org, dcheng, yukishiino+watch_chromium.org, yusukes+watch_chromium.org, ben+mojo_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, mikhal+watch_chromium.org, abarth-chromium, nona+watch_chromium.org, tdanderson+views_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, hubbe+watch_chromium.org, jennb, imcheng+watch_chromium.org, jasonroberts+watch_google.com, penghuang+watch_chromium.org, jianli, feature-media-reviews_chromium.org, yzshen+watch_chromium.org, ben+views_chromium.org, hclam+watch_chromium.org, tfarina, avayvod+watch_chromium.org, Dmitry Titov, pwestin+watch_google.com, Aaron Boodman, darin (slow to review), James Su
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 7

Patch Set 3 : review comments #

Patch Set 4 : sync #

Patch Set 5 : fix typo #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -21 lines) Patch
M base/process/process_metrics_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.cc View 1 2 3 4 5 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_incognito_apitest.cc View 1 2 3 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 3 4 3 chunks +27 lines, -3 lines 0 comments Download
M chrome/browser/ui/global_error/global_error_service_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/docked_panel_browsertest.cc View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 1 2 3 4 5 2 chunks +10 lines, -3 lines 0 comments Download
M components/bookmarks/browser/bookmark_utils_unittest.cc View 1 2 3 4 5 1 chunk +7 lines, -1 line 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 2 3 4 5 1 chunk +7 lines, -1 line 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
jam
6 years, 5 months ago (2014-07-23 05:32:18 UTC) #1
viettrungluu
https://codereview.chromium.org/417453002/diff/20001/chrome/browser/ssl/ssl_browser_tests.cc File chrome/browser/ssl/ssl_browser_tests.cc (right): https://codereview.chromium.org/417453002/diff/20001/chrome/browser/ssl/ssl_browser_tests.cc#newcode453 chrome/browser/ssl/ssl_browser_tests.cc:453: #define MAYBE_TestHTTPSExpiredCertAndProceed DISABLED_TestHTTPSExpiredCertAndProceed nit (here and below): you can ...
6 years, 5 months ago (2014-07-23 15:26:43 UTC) #2
jam
https://codereview.chromium.org/417453002/diff/20001/chrome/browser/ssl/ssl_browser_tests.cc File chrome/browser/ssl/ssl_browser_tests.cc (right): https://codereview.chromium.org/417453002/diff/20001/chrome/browser/ssl/ssl_browser_tests.cc#newcode453 chrome/browser/ssl/ssl_browser_tests.cc:453: #define MAYBE_TestHTTPSExpiredCertAndProceed DISABLED_TestHTTPSExpiredCertAndProceed On 2014/07/23 15:26:42, viettrungluu wrote: > ...
6 years, 5 months ago (2014-07-23 16:02:07 UTC) #3
viettrungluu
lgtm
6 years, 5 months ago (2014-07-23 16:19:49 UTC) #4
jabdelmalek
The CQ bit was checked by jabdelmalek@google.com
6 years, 4 months ago (2014-07-31 20:16:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/417453002/40001
6 years, 4 months ago (2014-07-31 20:18:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 20:20:10 UTC) #7
commit-bot: I haz the power
Failed to apply patch for ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-07-31 20:20:11 UTC) #8
jam
The CQ bit was checked by jam@chromium.org
6 years, 4 months ago (2014-07-31 20:50:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/417453002/60001
6 years, 4 months ago (2014-07-31 20:53:20 UTC) #10
jam
The CQ bit was checked by jam@chromium.org
6 years, 4 months ago (2014-07-31 23:04:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/417453002/80001
6 years, 4 months ago (2014-07-31 23:05:36 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-01 13:40:51 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 17:27:41 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/2489)
6 years, 4 months ago (2014-08-01 17:27:43 UTC) #15
jam
The CQ bit was checked by jam@chromium.org
6 years, 4 months ago (2014-08-11 05:38:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/417453002/80001
6 years, 4 months ago (2014-08-11 05:39:25 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-11 05:42:25 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 05:43:38 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/1657)
6 years, 4 months ago (2014-08-11 05:43:41 UTC) #20
jam
The CQ bit was checked by jam@chromium.org
6 years, 4 months ago (2014-08-11 14:57:23 UTC) #21
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 14:57:48 UTC) #22

Powered by Google App Engine
This is Rietveld 408576698