chrome/browser/extensions/extension_incognito_apitest.cc - Issue 417453002: Disable all the tests that are flaking more than 5% on Linux builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_incognito_apitest.cc

Issue 417453002: Disable all the tests that are flaking more than 5% on Linux builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/test/component_updater_service_unittest.cc ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_incognito_apitest.cc

diff --git a/chrome/browser/extensions/extension_incognito_apitest.cc b/chrome/browser/extensions/extension_incognito_apitest.cc

index b43833c0e69e3293c96e50106fa5337c53443665..c0ac869b21900185dfbb1e123e6474b6b5c8566e 100644

--- a/chrome/browser/extensions/extension_incognito_apitest.cc

+++ b/chrome/browser/extensions/extension_incognito_apitest.cc

@@ -184,14 +184,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, IncognitoDisabled) {

EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();

}

-#if defined(OS_WIN) || defined(OS_MACOSX)

-// http://crbug.com/104438.

-#define MAYBE_IncognitoPopup DISABLED_IncognitoPopup

-#else

-#define MAYBE_IncognitoPopup IncognitoPopup

-#endif

// Test that opening a popup from an incognito browser window works properly.

-IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_IncognitoPopup) {

+// http://crbug.com/180759.

+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_IncognitoPopup) {

host_resolver()->AddRule("*", "127.0.0.1");

ASSERT_TRUE(StartEmbeddedTestServer());