Issue 417133002: DevTools: [JSDocValidator] Require enum keys to start with an uppercase letter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 417133002: DevTools: [JSDocValidator] Require enum keys to start with an uppercase letter (Closed)

Created:
6 years, 5 months ago by apavlov

Modified:
6 years, 5 months ago

Reviewers:
sergeyv

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: [JSDocValidator] Require enum keys to start with an uppercase letter R=sergeyv NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178926

Patch Set 1 #

Patch Set 2 : Remove bad @enum annotation for WebInspector.AuditRule.SeverityOrder #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
M	Source/devtools/front_end/audits/AuditsPanel.js	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/devtools/scripts/compiler-runner/closure-runner.jar	View		Binary file		0 comments	Download
M	Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/417133002/20001

6 years, 5 months ago (2014-07-25 11:16:53 UTC) #5

Message was sent while issue was closed.

Change committed as 178926

Expand Messages | Collapse Messages