Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2159)

Unified Diff: Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java

Issue 417133002: DevTools: [JSDocValidator] Require enum keys to start with an uppercase letter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove bad @enum annotation for WebInspector.AuditRule.SeverityOrder Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/scripts/compiler-runner/closure-runner.jar ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java
diff --git a/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java b/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java
index 0ba48eb8aaaccb640ad2fbca039bb740c1e8b8b3..43b956b2a36805dbe41301a4d08f2d25e4c9a168 100644
--- a/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java
+++ b/Source/devtools/scripts/compiler-runner/src/org/chromium/devtools/compiler/DevToolsCodingConvention.java
@@ -7,11 +7,16 @@ public class DevToolsCodingConvention extends CodingConventions.Proxy {
private static final long serialVersionUID = 1L;
public DevToolsCodingConvention() {
- super(CodingConventions.getDefault());
+ super(CodingConventions.getDefault());
}
@Override
public boolean isPrivate(String name) {
- return name.length() > 1 && name.charAt(0) == '_' && name.charAt(1) != '_';
+ return name.length() > 1 && name.charAt(0) == '_' && name.charAt(1) != '_';
+ }
+
+ @Override
+ public boolean isValidEnumKey(String key) {
+ return !key.isEmpty() && Character.isUpperCase(key.charAt(0));
}
}
« no previous file with comments | « Source/devtools/scripts/compiler-runner/closure-runner.jar ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698