Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 417123003: Some small ASTC optimizations (Closed)

Created:
6 years, 5 months ago by krajcevski
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/utils/SkTextureCompressor_ASTC.cpp View 1 4 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
krajcevski
6 years, 5 months ago (2014-07-25 16:03:29 UTC) #1
robertphillips
lgtm + a comment request https://codereview.chromium.org/417123003/diff/1/src/utils/SkTextureCompressor_ASTC.cpp File src/utils/SkTextureCompressor_ASTC.cpp (right): https://codereview.chromium.org/417123003/diff/1/src/utils/SkTextureCompressor_ASTC.cpp#newcode190 src/utils/SkTextureCompressor_ASTC.cpp:190: } else { // ...
6 years, 5 months ago (2014-07-25 16:11:41 UTC) #2
krajcevski
https://codereview.chromium.org/417123003/diff/1/src/utils/SkTextureCompressor_ASTC.cpp File src/utils/SkTextureCompressor_ASTC.cpp (right): https://codereview.chromium.org/417123003/diff/1/src/utils/SkTextureCompressor_ASTC.cpp#newcode190 src/utils/SkTextureCompressor_ASTC.cpp:190: } else { On 2014/07/25 16:11:41, robertphillips wrote: > ...
6 years, 5 months ago (2014-07-25 17:12:05 UTC) #3
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 5 months ago (2014-07-25 17:12:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/417123003/20001
6 years, 5 months ago (2014-07-25 17:12:31 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 17:23:46 UTC) #6
Message was sent while issue was closed. 
Change committed as 4881a4d932832c407cc6624460415f624836d7d8

Powered by Google App Engine
This is Rietveld 408576698