Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 41703002: Fix GN unit tests (Closed)

Created:
7 years, 2 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Fix GN unit tests Various uses or $arch were not updated in the script writing code and in the expected output from when I changed how this works. This updates the script target writer and updates the test expectations. This moves the creation of the output directory from the build settings to the script execute code. I added this previously because the output directory wasn't always created by the time the windows toolchain setup script was run. But lots of tests don't bother to set the source root, and we don't want the tests creating directories randomly anyway. So this moves the creation to when we need it, although most of the time it will be a NOP. I added a build file for device/usb because I was bored last night. BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
M tools/gn/build_settings.h View 1 chunk +1 line, -2 lines 0 comments Download
M tools/gn/build_settings.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/gn/function_exec_script.cc View 1 chunk +8 lines, -0 lines 1 comment Download
M tools/gn/ninja_binary_target_writer_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/gn/ninja_script_target_writer.cc View 1 chunk +5 lines, -1 line 0 comments Download
M tools/gn/ninja_script_target_writer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M tools/gn/secondary/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A tools/gn/secondary/device/usb/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
7 years, 2 months ago (2013-10-24 21:43:44 UTC) #1
scottmg
7 years, 2 months ago (2013-10-24 21:47:20 UTC) #2
lgtm

https://codereview.chromium.org/41703002/diff/1/tools/gn/function_exec_script.cc
File tools/gn/function_exec_script.cc (right):

https://codereview.chromium.org/41703002/diff/1/tools/gn/function_exec_script...
tools/gn/function_exec_script.cc:358: file_util::CreateDirectory(startup_dir);
racing is silently ok on all platforms? (looks ok on windows, but i didn't check
all of them)

Powered by Google App Engine
This is Rietveld 408576698