tools/gn/build_settings.cc - Issue 41703002: Fix GN unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/build_settings.cc

Issue 41703002: Fix GN unit tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/build_settings.cc

diff --git a/tools/gn/build_settings.cc b/tools/gn/build_settings.cc

index af81467007c59de5b98665d5cc790baac051067c..0a75569b1dbbf7211e61d6eef63ef30ac4533e50 100644

--- a/tools/gn/build_settings.cc

+++ b/tools/gn/build_settings.cc

@@ -46,9 +46,6 @@ void BuildSettings::SetSecondarySourcePath(const SourceDir& d) {

void BuildSettings::SetBuildDir(const SourceDir& d) {

build_dir_ = d;

build_to_source_dir_string_ = InvertDir(d);

- DCHECK(!root_path_.empty());

- file_util::CreateDirectory(build_dir_.Resolve(root_path_));

}

base::FilePath BuildSettings::GetFullPath(const SourceFile& file) const {