Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 417013003: Move statistical functions in bisect script to their own module. (Closed)

Created:
6 years, 5 months ago by qyearsley
Modified:
6 years, 4 months ago
Reviewers:
prasadv, shatch
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Move statistical functions to another module. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286137

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebased and fixed test failures #

Total comments: 1

Patch Set 5 : Respond to nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -219 lines) Patch
A tools/auto_bisect/math_utils.py View 1 2 3 4 1 chunk +130 lines, -0 lines 0 comments Download
A tools/auto_bisect/math_utils_test.py View 1 chunk +62 lines, -0 lines 0 comments Download
M tools/bisect-perf-regression.py View 1 2 3 10 chunks +19 lines, -133 lines 0 comments Download
M tools/bisect-perf-regression_test.py View 1 2 3 8 chunks +39 lines, -82 lines 0 comments Download
M tools/run-bisect-perf-regression.py View 1 2 3 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qyearsley
As the CL title indicates, the point is just to move some more functions out ...
6 years, 5 months ago (2014-07-24 23:35:45 UTC) #1
prasadv
lgtm https://codereview.chromium.org/417013003/diff/60001/tools/auto_bisect/math_utils.py File tools/auto_bisect/math_utils.py (right): https://codereview.chromium.org/417013003/diff/60001/tools/auto_bisect/math_utils.py#newcode106 tools/auto_bisect/math_utils.py:106: denominator2 += 1.0 / len(current_set) Nit: if current_set ...
6 years, 4 months ago (2014-07-28 21:31:17 UTC) #2
qyearsley
The CQ bit was checked by qyearsley@chromium.org
6 years, 4 months ago (2014-07-29 01:10:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/417013003/80001
6 years, 4 months ago (2014-07-29 01:10:43 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 09:14:48 UTC) #5
Message was sent while issue was closed.
Change committed as 286137

Powered by Google App Engine
This is Rietveld 408576698