Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 416903002: Revert 285142 "Open the WrenchMenu on mouseover when dragging a ..." (Closed)

Created:
6 years, 5 months ago by Alexei Svitkine (slow)
Modified:
6 years, 5 months ago
Reviewers:
Devlin
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 285142 "Open the WrenchMenu on mouseover when dragging a ..." Caused ToolbarViewInteractiveUITest.TestWrenchMenuOpensOnDrag to start being flaky on Vista: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/47593/steps/interactive_ui_tests/logs/TestWrenchMenuOpensOnDrag e.g. test output: ToolbarViewInteractiveUITest.TestWrenchMenuOpensOnDrag (run #1): [ RUN ] ToolbarViewInteractiveUITest.TestWrenchMenuOpensOnDrag c:\b\build\slave\win_builder\build\src\chrome\browser\ui\views\toolbar\toolbar_view_interactive_uitest.cc(145): error: Value of: browser_actions()->VisibleBrowserActions() Actual: 0 Expected: 1u Which is: 1 [ FAILED ] ToolbarViewInteractiveUITest.TestWrenchMenuOpensOnDrag, where TypeParam = and GetParam() = (374 ms) > Open the WrenchMenu on mouseover when dragging a browser action > > Enable dragging from the main container to the overflow container by opening the > wrench menu when hovering over the button while dragging a browser action. This > also requires keeping the menu open while the drag is happening. > > Note: this doesn't fix drag calculations for the overflow menu. > In an effort to keep these patches small, that will come later. > > BUG=393038 > > Review URL: https://codereview.chromium.org/399143004 TBR=rdevlin.cronin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -559 lines) Patch
M trunk/src/chrome/browser/ui/toolbar/wrench_menu_model.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/extensions/browser_action_drag_data.h View 2 chunks +4 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/extensions/browser_action_drag_data.cc View 2 chunks +3 lines, -23 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/menu_test_base.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/menu_test_base.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/menu_view_drag_and_drop_test.cc View 3 chunks +0 lines, -72 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/browser_action_view.h View 2 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/browser_action_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/browser_actions_container.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/browser_actions_container.cc View 3 chunks +6 lines, -15 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/browser_actions_container_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h View 2 chunks +2 lines, -21 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc View 3 chunks +4 lines, -23 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/toolbar_view.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/toolbar_view.cc View 2 chunks +24 lines, -32 lines 0 comments Download
D trunk/src/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc View 1 chunk +0 lines, -157 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/wrench_menu.h View 4 chunks +8 lines, -21 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/wrench_menu.cc View 7 chunks +12 lines, -21 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/wrench_toolbar_button.h View 2 chunks +1 line, -33 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/toolbar/wrench_toolbar_button.cc View 2 chunks +3 lines, -68 lines 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/views/controls/menu/menu_controller.h View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/ui/views/controls/menu/menu_controller.cc View 3 chunks +3 lines, -10 lines 0 comments Download
M trunk/src/ui/views/controls/menu/menu_runner.h View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/ui/views/controls/menu/menu_runner_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alexei Svitkine (slow)
6 years, 5 months ago (2014-07-24 17:01:59 UTC) #1
Alexei Svitkine (slow)
6 years, 5 months ago (2014-07-24 17:02:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r285301.

Powered by Google App Engine
This is Rietveld 408576698