Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: trunk/src/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc

Issue 416903002: Revert 285142 "Open the WrenchMenu on mouseover when dragging a ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc
===================================================================
--- trunk/src/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc (revision 285300)
+++ trunk/src/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc (working copy)
@@ -7,7 +7,6 @@
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
-#include "chrome/browser/ui/views/toolbar/wrench_menu.h"
#include "ui/views/controls/menu/menu_item_view.h"
namespace {
@@ -19,28 +18,15 @@
} // namespace
-ExtensionToolbarMenuView::ExtensionToolbarMenuView(Browser* browser,
- WrenchMenu* wrench_menu)
- : browser_(browser),
- wrench_menu_(wrench_menu),
- container_(NULL),
- browser_actions_container_observer_(this) {
- BrowserActionsContainer* main =
- BrowserView::GetBrowserViewForBrowser(browser_)
- ->toolbar()->browser_actions();
+ExtensionToolbarMenuView::ExtensionToolbarMenuView(Browser* browser)
+ : browser_(browser) {
+ BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser);
container_ = new BrowserActionsContainer(
browser_,
NULL, // No owner view, means no extra keybindings are registered.
- main);
+ browser_view->GetToolbarView()->browser_actions());
container_->Init();
AddChildView(container_);
-
- // If we were opened for a drop command, we have to wait for the drop to
- // finish so we can close the wrench menu.
- if (wrench_menu_->for_drop()) {
- browser_actions_container_observer_.Add(container_);
- browser_actions_container_observer_.Add(main);
- }
}
ExtensionToolbarMenuView::~ExtensionToolbarMenuView() {
@@ -62,8 +48,3 @@
SetBounds(views::MenuItemView::label_start(), 0, sz.width(), height);
container_->SetBounds(0, 0, sz.width(), height);
}
-
-void ExtensionToolbarMenuView::OnBrowserActionDragDone() {
- DCHECK(wrench_menu_->for_drop());
- wrench_menu_->CloseMenu();
-}

Powered by Google App Engine
This is Rietveld 408576698