Remove newlib header workaround for run_posix_memalign_test.

Remove newlib header workaround for run_posix_memalign_test.

Newlib should declare it now for NaCl.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3718
R=mcgrathr@chromium.org

Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12445

[Roland McGrath, 2013-11-23 00:03:49]

lgtm

[jvoung (off chromium), 2013-11-25 19:05:22]

Committed patchset #2 manually as r12445 (presubmit successful).

[Mark Seaborn, 2013-12-05 21:16:21]

This change broke the archived-frontend tests on the PNaCl FYI bots:

http://build.chromium.org/p/client.nacl.toolchain/builders/linux-pnacl-x86_64...

tests/libc/posix_memalign.c:23:17: error: implicit declaration of function
'posix_memalign' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
      int err = posix_memalign((void **)&outp,

I think the long term fix is to remove the archived-frontend tests and replace
them with tests that capture snapshots of pexes.

But for now, could you fix this by bumping FEATURE_VERSION and making this test
conditional on that?  (tests/toolchain/nacl.scons does something like that for
conditionalising the SJLJ EH tests.)

[jvoung (off chromium), 2013-12-05 21:36:01]

On 2013/12/05 21:16:21, Mark Seaborn wrote:
> This change broke the archived-frontend tests on the PNaCl FYI bots:
> 
>
http://build.chromium.org/p/client.nacl.toolchain/builders/linux-pnacl-x86_64...
> 
> tests/libc/posix_memalign.c:23:17: error: implicit declaration of function
> 'posix_memalign' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>       int err = posix_memalign((void **)&outp,
> 
> I think the long term fix is to remove the archived-frontend tests and replace
> them with tests that capture snapshots of pexes.

Yeah we'd have to snapshot programs plus their test harness -- for example, we
have to watch out if we modify a test relies on golden output.

> 
> But for now, could you fix this by bumping FEATURE_VERSION and making this
test
> conditional on that?  (tests/toolchain/nacl.scons does something like that for
> conditionalising the SJLJ EH tests.)

Okay I'll send out a CL.