Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: Tools/GardeningServer/ui/ct-test-list.html

Issue 416673003: Show non-webkit test failures in the failure stream (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-test-list.html
diff --git a/Tools/GardeningServer/ui/ct-test-list.html b/Tools/GardeningServer/ui/ct-test-list.html
index 73f970a3e36925af648e2b63637296055c275738..12477f87e74ab4d189a2c04a469e0df53f4a6c5c 100644
--- a/Tools/GardeningServer/ui/ct-test-list.html
+++ b/Tools/GardeningServer/ui/ct-test-list.html
@@ -11,14 +11,19 @@ found in the LICENSE file.
display: block;
}
</style>
- <template repeat="{{testName in tests}}">
- <div><a href="{{testName|flakinessDashboardURL}}">{{testName}}</a></div>
+ <template repeat="{{ test in tests }}">
+ <!-- FIXME: Find a less redundant UI than repeating the step on each line. -->
+ <div>
+ {{ test.step }}
+ <template if="{{ test.testName }}"><a href="{{ test | flakinessDashboardURL }}">{{ test.testName }}</a></template>
+ <template if="{{ !test.testName }}"><b>whole step failed</b></template>
+ </div>
</template>
</template>
<script>
Polymer({
- flakinessDashboardURL: function(testName) {
- return ui.urlForFlakinessDashboard([testName]);
+ flakinessDashboardURL: function(test) {
+ return ui.urlForFlakinessDashboard(test.testName, test.step);
},
});
</script>
« no previous file with comments | « Tools/GardeningServer/ui/ct-results-panel-tests.html ('k') | Tools/GardeningServer/ui/ct-test-list-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698