Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 416633002: Cleanup Chrome's LevelDB env to conform to C++ style guidelines. (Closed)

Created:
6 years, 5 months ago by cmumford
Modified:
6 years, 5 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup Chrome's LevelDB env to conform to C++ style guidelines. For IndexedDB files in third_party/leveldatabase: 1. "git cl lint" now runs with no warnings. 2. "git cl format" makes no changes. BUG=381456 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285440

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed Windows build. #

Patch Set 3 : Added using leveldb_env::ChromiumEnvWin #

Patch Set 4 : Fixed snprintf with pid_t #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -63 lines) Patch
M third_party/leveldatabase/chromium_logger.h View 1 2 3 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/leveldatabase/env_chromium.h View 4 chunks +7 lines, -2 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 7 chunks +18 lines, -12 lines 0 comments Download
M third_party/leveldatabase/env_chromium_stdio.h View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/leveldatabase/env_chromium_stdio.cc View 2 chunks +22 lines, -11 lines 0 comments Download
M third_party/leveldatabase/env_chromium_unittest.cc View 1 2 7 chunks +38 lines, -23 lines 0 comments Download
M third_party/leveldatabase/env_chromium_win.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/leveldatabase/env_chromium_win.cc View 1 1 chunk +12 lines, -5 lines 0 comments Download
M third_party/leveldatabase/env_idb.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
cmumford
6 years, 5 months ago (2014-07-23 19:05:13 UTC) #1
jsbell
lgtm apart from... https://codereview.chromium.org/416633002/diff/1/third_party/leveldatabase/env_chromium.cc File third_party/leveldatabase/env_chromium.cc (right): https://codereview.chromium.org/416633002/diff/1/third_party/leveldatabase/env_chromium.cc#newcode22 third_party/leveldatabase/env_chromium.cc:22: #include "third_parth/leveldatabase/env_chromium_win.h" typo: third_part**h**
6 years, 5 months ago (2014-07-23 19:09:09 UTC) #2
jsbell
Since this is Chromium's leveldb support, not IndexedDB specific, you may want to tweak the ...
6 years, 5 months ago (2014-07-23 19:09:58 UTC) #3
cmumford
Windows build was broken in a few other places. Fixed now.
6 years, 5 months ago (2014-07-23 22:03:29 UTC) #4
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 5 months ago (2014-07-23 22:03:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/416633002/20001
6 years, 5 months ago (2014-07-23 22:07:07 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 02:18:40 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 02:24:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_dbg/builds/44141)
6 years, 5 months ago (2014-07-24 02:24:36 UTC) #9
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 5 months ago (2014-07-24 15:44:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/416633002/40001
6 years, 5 months ago (2014-07-24 15:45:55 UTC) #11
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 5 months ago (2014-07-24 20:09:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/416633002/60001
6 years, 5 months ago (2014-07-24 20:13:47 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 23:36:58 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 00:42:37 UTC) #15
Message was sent while issue was closed.
Change committed as 285440

Powered by Google App Engine
This is Rietveld 408576698