Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: third_party/leveldatabase/env_chromium.h

Issue 416633002: Cleanup Chrome's LevelDB env to conform to C++ style guidelines. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed snprintf with pid_t Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/leveldatabase/chromium_logger.h ('k') | third_party/leveldatabase/env_chromium.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/leveldatabase/env_chromium.h
diff --git a/third_party/leveldatabase/env_chromium.h b/third_party/leveldatabase/env_chromium.h
index e0278857af4d803e7c264c66f4967c4c1803e572..4ce3190eb2f0fb607ed98a770ef476afae482027 100644
--- a/third_party/leveldatabase/env_chromium.h
+++ b/third_party/leveldatabase/env_chromium.h
@@ -8,8 +8,11 @@
#include <deque>
#include <map>
#include <set>
+#include <string>
+#include <vector>
#include "base/files/file.h"
+#include "base/files/file_path.h"
#include "base/metrics/histogram.h"
#include "leveldb/env.h"
#include "port/port_chromium.h"
@@ -103,6 +106,8 @@ class ChromiumEnv : public leveldb::Env,
public RetrierProvider,
public WriteTracker {
public:
+ typedef void(ScheduleFunc)(void*);
+
static bool MakeBackup(const std::string& fname);
static base::FilePath CreateFilePath(const std::string& file_path);
static const char* FileErrorString(::base::File::Error error);
@@ -121,7 +126,7 @@ class ChromiumEnv : public leveldb::Env,
virtual leveldb::Status LockFile(const std::string& fname,
leveldb::FileLock** lock);
virtual leveldb::Status UnlockFile(leveldb::FileLock* lock);
- virtual void Schedule(void (*function)(void*), void* arg);
+ virtual void Schedule(ScheduleFunc*, void* arg);
virtual void StartThread(void (*function)(void* arg), void* arg);
virtual leveldb::Status GetTestDirectory(std::string* path);
virtual uint64_t NowMicros();
@@ -206,4 +211,4 @@ class ChromiumEnv : public leveldb::Env,
} // namespace leveldb_env
-#endif
+#endif // THIRD_PARTY_LEVELDATABASE_ENV_CHROMIUM_H_
« no previous file with comments | « third_party/leveldatabase/chromium_logger.h ('k') | third_party/leveldatabase/env_chromium.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698