Issue 416563002: Abort analysis server integration tests in the event of async errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 416563002: Abort analysis server integration tests in the event of async errors. (Closed)

Created:
6 years, 5 months ago by Paul Berry

Modified:
6 years, 5 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Abort analysis server integration tests in the event of async errors. Previously, if an asynchronous error occurred during execution of an integration test (e.g. if the subprocess generated unexpected output), the error would not get propagated up to the test runner, so the test would continue to run until a timeout. Use expectAsync to propagate errors up to the test runner, and add code to reflective_tests.dart to workaround 20153 so that asynchronous errors cause the test to abort even if the test is waiting on a future.

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -14 lines)			Patch
	M	pkg/analysis_server/test/integration/integration_tests.dart	View		6 chunks	+18 lines, -8 lines	0 comments	Download
	M	pkg/analysis_testing/lib/reflective_tests.dart	View		1 chunk	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

I'm sorry, but I cannot review this CL. I don't know unittest well enough to ...

6 years, 5 months ago (2014-07-23 21:58:29 UTC) #2

Paul Berry

6 years, 5 months ago (2014-07-24 15:41:05 UTC) #3

On 2014/07/23 21:58:29, scheglov wrote:
> I'm sorry, but I cannot review this CL.
> I don't know unittest well enough to understand how this CL will change
behavior
> :-(

No problem.  Now that I have investigated further, I've realized that (a) fixing
bug 20153 in the unittest module is not that difficult, and (b) contrary to my
initial suspicions, expectAsync() is not in fact necessary to propagate the
errors once bug 20153 is fixed.  So none of this code makes sense anymore; I'm
closing this issue.

If you're curious, here's my CL to fix bug 20153:
https://codereview.chromium.org/416133002/

Expand Messages | Collapse Messages