Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 416403002: Keep new arrays allocated with 'new Array(N)' in fast mode (revisited) (Closed)

Created:
6 years, 4 months ago by danno
Modified:
6 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Keep new arrays allocated with 'new Array(N)' in fast mode (revisited) Also explicit length setting with a.length = N should remain in fast mode. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22645

Patch Set 1 #

Patch Set 2 : Fix everything #

Patch Set 3 : Nit #

Total comments: 1

Patch Set 4 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -65 lines) Patch
M src/array.js View 1 2 3 7 chunks +39 lines, -30 lines 0 comments Download
M src/elements.cc View 1 2 2 chunks +5 lines, -11 lines 0 comments Download
M src/objects.cc View 1 1 chunk +11 lines, -0 lines 0 comments Download
M src/runtime.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 2 chunks +38 lines, -5 lines 0 comments Download
M test/fuzz-natives/base.js View 1 2 chunks +5 lines, -1 line 0 comments Download
M test/mjsunit/allocation-site-info.js View 1 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/apply.js View 1 3 chunks +6 lines, -2 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/array-feedback.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/elements-kind.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/es7/object-observe.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/polymorph-arrays.js View 1 5 chunks +7 lines, -5 lines 0 comments Download
M test/mjsunit/regress/regress-2790.js View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/generate-runtime-tests.py View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
PTAL, part 2
6 years, 4 months ago (2014-07-25 12:59:33 UTC) #1
Toon Verwaest
lgtm https://codereview.chromium.org/416403002/diff/40001/src/array.js File src/array.js (right): https://codereview.chromium.org/416403002/diff/40001/src/array.js#newcode802 src/array.js:802: %NormalizeElements(array); Normalize deleted_elements
6 years, 4 months ago (2014-07-25 13:33:46 UTC) #2
danno
6 years, 4 months ago (2014-07-28 13:12:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r22645 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698