Issue 416393003: Make Demuxer::Stop() synchronous.

Issue 416393003: Make Demuxer::Stop() synchronous. (Closed)

Created:
6 years, 5 months ago by xhwang

Modified:
6 years, 3 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Make Demuxer::Stop() synchronous. BUG=349211 TEST=All existing tests pass. Committed: https://crrev.com/fcdacaf9c150d3ad8f31592daaadc38c01a65bb1 Cr-Commit-Position: refs/heads/master@{#292958}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -63 lines)			Patch
M	content/renderer/media/android/media_source_delegate.h	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/renderer/media/android/media_source_delegate.cc	View	1 2 3	2 chunks	+8 lines, -13 lines	0 comments	Download
M	media/base/demuxer.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	media/base/demuxer_perftest.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	media/base/mock_filters.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/pipeline.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/base/pipeline_unittest.cc	View	1 2	13 chunks	+14 lines, -20 lines	0 comments	Download
M	media/filters/chunk_demuxer.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/chunk_demuxer.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/ffmpeg_demuxer.cc	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer_unittest.cc	View	1 2	3 chunks	+4 lines, -11 lines	0 comments	Download

Total messages: 7 (1 generated)

xhwang

xhwang@chromium.org changed reviewers: + acolwell@chromium.org

6 years, 3 months ago (2014-08-29 03:53:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/416393003/60001

6 years, 3 months ago (2014-09-02 17:32:18 UTC) #5

commit-bot: I haz the power

Committed patchset #4 (id:60001) as 33c27b926a8dd639e48547deda288966d2486145

6 years, 3 months ago (2014-09-02 18:14:37 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:19:26 UTC) #7

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/fcdacaf9c150d3ad8f31592daaadc38c01a65bb1
Cr-Commit-Position: refs/heads/master@{#292958}