Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: media/filters/ffmpeg_demuxer_unittest.cc

Issue 416393003: Make Demuxer::Stop() synchronous. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix android Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/ffmpeg_demuxer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/ffmpeg_demuxer_unittest.cc
diff --git a/media/filters/ffmpeg_demuxer_unittest.cc b/media/filters/ffmpeg_demuxer_unittest.cc
index 76ccba2259a4f1faa417a68f9b6dd03e2b0b8f9c..0f8199e298e385ed00e02d53fb424141e1262455 100644
--- a/media/filters/ffmpeg_demuxer_unittest.cc
+++ b/media/filters/ffmpeg_demuxer_unittest.cc
@@ -67,11 +67,8 @@ class FFmpegDemuxerTest : public testing::Test {
FFmpegDemuxerTest() {}
virtual ~FFmpegDemuxerTest() {
- if (demuxer_) {
- WaitableMessageLoopEvent event;
- demuxer_->Stop(event.GetClosure());
- event.RunAndWait();
- }
+ if (demuxer_)
+ demuxer_->Stop();
}
void CreateDemuxer(const std::string& name) {
@@ -753,9 +750,7 @@ TEST_F(FFmpegDemuxerTest, Stop) {
DemuxerStream* audio = demuxer_->GetStream(DemuxerStream::AUDIO);
ASSERT_TRUE(audio);
- WaitableMessageLoopEvent event;
- demuxer_->Stop(event.GetClosure());
- event.RunAndWait();
+ demuxer_->Stop();
// Reads after being stopped are all EOS buffers.
StrictMock<MockReadCB> callback;
@@ -914,9 +909,7 @@ TEST_F(FFmpegDemuxerTest, IsValidAnnexB) {
stream->Read(base::Bind(&ValidateAnnexB, stream));
message_loop_.Run();
- WaitableMessageLoopEvent event;
- demuxer_->Stop(event.GetClosure());
- event.RunAndWait();
+ demuxer_->Stop();
demuxer_.reset();
data_source_.reset();
}
« no previous file with comments | « media/filters/ffmpeg_demuxer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698